Skip to content

Conversation

@ahuseyn
Copy link
Member

@ahuseyn ahuseyn commented Jul 29, 2025

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Previously, WordPress connection failures lacked clear feedback. This update adds a proper error message when a 500 error occurs, improving debugging and usability.

Related Issue(s):

#2139

Testing

Automated tests and manual test on local env

Screenshots

Documentation Changes

Dependant PRs

@ahuseyn ahuseyn requested a review from a team as a code owner July 29, 2025 13:15
@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2025

🦋 Changeset detected

Latest commit: 1f33f56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@faustwp/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@ahuseyn ahuseyn linked an issue Jul 29, 2025 that may be closed by this pull request
1 task
@colinmurphy
Copy link
Member

@ahuseyn PR looks good to me. One small question I had was those the new check capture all 5XX errors or just 500.

@ahuseyn
Copy link
Member Author

ahuseyn commented Jul 31, 2025

@ahuseyn PR looks good to me. One small question I had was those the new check capture all 5XX errors or just 500.

Thanks @colinmurphy, good point, updated to catch all 5xx errors

Copy link
Member

@josephfusco josephfusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ahuseyn ahuseyn merged commit f5e1253 into canary Aug 4, 2025
16 checks passed
@ahuseyn ahuseyn deleted the fix-faust-secret-error-handling branch August 4, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error handling for validating the Faust Secret

4 participants